[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[ns] Bug in packet.h (affects ad hoc routing classes)



Hi,

Both IMEP and AODV use a macro from packet.h, DATA_PACKET, that is
severely outdated:

#define DATA_PACKET(type) ( (type) == PT_TCP || \
                            (type) == PT_TELNET || \
                            (type) == PT_CBR || \
                            (type) == PT_AUDIO || \
                            (type) == PT_VIDEO || \
                            (type) == PT_ACK \
                            )

Several data packet types, such as Message or UDP,  are not included in
this list, so the macro does not properly identify them as data packets.
In the case of TORA, using an agent whose packet type is not in the
macro will trigger a silent abort (see imepAgent::toraHeaderLength).
p_info::data_packet() in packet.h is also outdated. It is only used in
god.cc. I guess someone should commit an updated version... Thank you.

-- Felix Hernandez Campos