Comments for ns-2.1b5-current 1999-02-17

[Christian J|nsson <chj@lin.foa.se>]

I just tried to compile the current snapshot of ns-2.1b5 with egcs-1.1.1 on a 
Solaris 2.6 system. I have some comments that I don't know where to send so 
here it goes:

*** This is fishy,

rng.cc: In method `int RNG::command(int, const char *const *)':
rng.cc:231: warning: decimal integer constant is so large that it is unsigned


*** No problem, but could easily be fixed up,

ll.h:81: warning: return-type of `arpinput' defaults to `int'
ll.h:82: warning: return-type of `arprequest' defaults to `int'

*** Well, something might go in here RSN, or?,

classifier-addr.cc:67: warning: unused variable `class Tcl & tcl'
classifier-addr.cc: In method `int BcastAddressClassifier::command(int, const 
char *const *)':
classifier-addr.cc:133: warning: unused variable `class Tcl & tcl'

mac-802_11.cc: In method `int Mac802_11::check_pktCTRL()':
mac-802_11.cc:667: warning: unused variable `struct hdr_mac802_11 * dh'
mac-802_11.cc: In method `int Mac802_11::check_pktRTS()':
mac-802_11.cc:704: warning: unused variable `struct hdr_mac802_11 * dh'
mac-802_11.cc: In method `int Mac802_11::check_pktTx()':
mac-802_11.cc:750: warning: unused variable `struct hdr_mac802_11 * dh'

cmu-trace.cc: In method `void CMUTrace::recv(class Packet *, class Handler *)':
cmu-trace.cc:290: warning: unused variable `struct hdr_ip * ih'

dsr/dsragent.cc: In method `void DSRAgent::handlePktWithoutSR(struct SRPacket 
&, bool)':
dsr/dsragent.cc:539: warning: unused variable `struct hdr_sr * srh'

*** Could be something but I doubt it,

traffictrace.cc: In method `int TraceFile::setup()':
traffictrace.cc:150: warning: comparison between signed and unsigned
traffictrace.cc:168: warning: implicit declaration of function `int htonl(...)'

*** I'm not sure here, 

tcp-sink.cc: In method `void SackStack::reset()':
tcp-sink.cc:280: warning: ANSI C++ forbids declaration `i' with no type
tcp-sink.cc: In method `void SackStack::push(int = 0)':
tcp-sink.cc:289: warning: ANSI C++ forbids declaration `i' with no type
tcp-sink.cc: In method `void SackStack::pop(int = 0)':
tcp-sink.cc:296: warning: ANSI C++ forbids declaration `i' with no type
tcp-sink.cc: In method `SackStack::SackStack(int)':
tcp-sink.cc:306: warning: ANSI C++ forbids declaration `i' with no type

tcp-full.cc: In method `int ReassemblyQueue::gensack(int *, int)':
tcp-full.cc:1995: warning: ANSI C++ forbids declaration `i' with no type

codeword.cc: In method `class ExtraLongUInt ExtraLongUInt::operator +(const 
class ExtraLongUInt &) const':
codeword.cc:351: warning: ANSI C++ forbids declaration `shift' with no type

dsr/path.cc: In method `char * Path::dump() const':
dsr/path.cc:363: warning: ANSI C++ forbids declaration `which' with no type

*** Oops, what's this,

tcp-fack.h: In method `FackTcpAgent::FackTcpAgent()':
tcp-fack.h:63: warning: member initializers for `unsigned char 
FackTcpAgent::timeout_'
tcp-fack.h:65: warning:   and `double FackTcpAgent::wintrim_'
tcp-fack.cc:49: warning:   will be re-ordered to match declaration order

dsdv/dsdv.cc:550: warning: converting of negative value `-1' to `unsigned int'
dsdv/dsdv.cc:551: warning: converting of negative value `-1' to `unsigned int'

queue-monitor.h: In method `QueueMonitor::QueueMonitor()':
In file included from queue-monitor.cc:40:
queue-monitor.h:55: no matching function for call to `QueueMonitor::bind 
(char[11], long long int *)'
../tclcl/tclcl.h:171: candidates are: TclObject::bind(const char *, TracedInt 
*)
../tclcl/tclcl.h:172:                 TclObject::bind(const char *, 
TracedDouble *)
../tclcl/tclcl.h:173:                 TclObject::bind(const char *, double *)
../tclcl/tclcl.h:176:                 TclObject::bind(const char *, int *)
queue-monitor.h:56: no matching function for call to `QueueMonitor::bind 
(char[11], long long int *)'
../tclcl/tclcl.h:171: candidates are: TclObject::bind(const char *, TracedInt 
*)
../tclcl/tclcl.h:172:                 TclObject::bind(const char *, 
TracedDouble *)
../tclcl/tclcl.h:173:                 TclObject::bind(const char *, double *)
../tclcl/tclcl.h:176:                 TclObject::bind(const char *, int *)
queue-monitor.h:57: no matching function for call to `QueueMonitor::bind 
(char[13], long long int *)'
../tclcl/tclcl.h:171: candidates are: TclObject::bind(const char *, TracedInt 
*)
../tclcl/tclcl.h:172:                 TclObject::bind(const char *, 
TracedDouble *)
../tclcl/tclcl.h:173:                 TclObject::bind(const char *, double *)
../tclcl/tclcl.h:176:                 TclObject::bind(const char *, int *)
queue-monitor.h:58: no matching function for call to `QueueMonitor::bind 
(char[13], long long int *)'
../tclcl/tclcl.h:171: candidates are: TclObject::bind(const char *, TracedInt 
*)
../tclcl/tclcl.h:172:                 TclObject::bind(const char *, 
TracedDouble *)
../tclcl/tclcl.h:173:                 TclObject::bind(const char *, double *)
../tclcl/tclcl.h:176:                 TclObject::bind(const char *, int *)
*** Error code 1

Any comments are appreciated atleast by me, perhaps not by the list members...


--
Christian J�nsson                      (MIME) E-mail:        chj@lin.foa.se
Division of Communication Systems             Telephone: (+46) 13  37 81 05
Dep't of C&C Warfare Technology               Telefax:   (+46) 13  37 80 49
Sweden's Defence Research Establishment       Mobile:    (+46) 70 575 61 06