[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: code in classifer.h



Yes this is a range check but I all looks like it could always be true.
It looks like an or was used when an and should have been.

jcb

On Thu, 25 Feb 1999, John Heidemann wrote:

> On Thu, 25 Feb 1999 14:36:05 CST, Zhenhai Duan wrote: 
> >Did someone think the following code is strange in classifier.h
> >
> >	inline NsObject* slot(int slot) {
> >		if ((slot >= 0) || (slot < nslot_))
> >			return slot_[slot];
> >		return 0;
> >	}
> 
> Can you be more specific about your concern?
> Looks like a range check to me.
> 
>    -John Heidemann
>