[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: oddity in both ns and nam config.h



Fixed. 

- Haobo

On Fri, 15 Oct 1999, Lloyd Wood wrote:

> http://www-mash.cs.berkeley.edu/cgi-bin/cvsweb/ns-2/config.h?rev=1.41
> http://www-mash.cs.berkeley.edu/cgi-bin/cvsweb/nam-1/config.h?rev=1.8
> 
> I'm puzzled by some of the directives in config.h. It's odd, and
> it's consistently odd. I don't think:
> 
> #ifdef WIN32
> /* following directives are if we're on WIN32 */
> #ifdef WIN32
> /* now we're really absolutely sure we're on WIN32! */
> /* to be really sure we may have to nest another one... */
> 
> makes that much sense. I'd be happier if they weren't nested, and if
> there were two rather than one
> 
> #endif /* WIN32 */
> 
> so that this, while still redundant, at least _seemed_ intentional.
> 
> thanks,
> 
> L.
> 
> <[email protected]>PGP<http://www.ee.surrey.ac.uk/Personal/L.Wood/>
> 
> ---------- Forwarded message ----------
> Date: Thu, 14 Oct 1999 09:35:10 -0700 (PDT)
> From: Haobo Yu <[email protected]>
> To: Lloyd Wood <[email protected]>
> Subject: Re: nam config.h
> 
> This problem exists in both ns and nam. :( Thanks for the info.
> 
> - Haobo
> 
> On Wed, 13 Oct 1999, Lloyd Wood wrote:
> 
> > I've just looked at:
> > 
> > http://www-mash.cs.berkeley.edu/cgi-bin/cvsweb/nam-1/config.h?rev=1.8
> > 
> > 
> > #ifdef WIN32
> > 
> > #include <windows.h>
> > #include <winsock.h>
> > #include <time.h>               /* For clock_t */
> > 
> > #ifdef WIN32
> > #include <minmax.h>
> > #define NOMINMAX
> > #undef min
> > #undef max
> > #undef abs
> > #endif
> > 
> > that has to be wrong. There's only one 
> > 
> > #endif /* WIN32 */
> > 
> > later on. Sure, there are 14 #if and 14 #endif statements, but I think
> > that's accidental.
> > 
> > L.
> > 
> > <[email protected]>PGP<http://www.ee.surrey.ac.uk/Personal/L.Wood/>
> 
> 
>