Re: [ns] A few issues (fulltcp, parameters...) related to webtraf.**

[David Ros <David.Ros@irisa.fr>]

Lloyd Wood wrote:
> 
> > Alas, the fixes suggested by Felix have -- AFAIK -- never been taken
> > into account in newer versions of tcp-full...
> 
> Well, not exactly as Felix suggested.
> 
> http://www.isi.edu/cgi-bin/nsnam/cvsweb/ns-2/tcp-full.cc
> 
> 1.81 Wed Aug 23 1:05:13 US/Pacific 2000 by haoboy
> Diffs to 1.80
> 
> Fix for done{} callback by Felix Hernandex Campos
> <fhernand@cs.unc.edu>
> 

Sure, it's not the same fix:

* close_ is still (erroneously) redefined in tcp-full.h

* Felix's solution, consisting in calling finish() instead of done{}
when the connection closes, is IMHO the right thing to do. finish() not
only does the done{} callback, it also does some cleanup---like
canceling timers that might get (erroneously) triggered later.

See a more recent post (12 Dec 2000) from Felix:
http://www.isi.edu/nsnam/archive/ns-users/webarch/2000/msg06021.html


> that doesn't address the reuse problem.
> 

Felix's patches address one side of the problem. As he said in his post:
reusing != done callback, but they are related, though. You also have to
reset() the agent to reuse it.


...or am I missing something?


Cheers,

David.

=================================================================
David ROS                               mailto:David.Ros@irisa.fr
IRISA/INRIA, Campus de Beaulieu,        Phone:  +33 2 99 84 72 98
35042 Rennes Cedex, France              Fax:    +33 2 99 84 25 29

"Any sufficiently advanced  
technology is indistinguishable from magic." --- Arthur C. Clarke